Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf_rpc: Add test for ot_message allocations. #18902

Merged
merged 1 commit into from
Nov 20, 2024
Merged

nrf_rpc: Add test for ot_message allocations. #18902

merged 1 commit into from
Nov 20, 2024

Conversation

canisLupus1313
Copy link
Contributor

Commit adds unit tests for ot message manipulation in nrf rpc Openthread part.

@canisLupus1313 canisLupus1313 requested review from a team as code owners November 14, 2024 23:53
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 14, 2024
@canisLupus1313 canisLupus1313 removed the request for review from a team November 14, 2024 23:54
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 14, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: bf937c8ecb3d36d906c47323f05e3f1337c1bdab

more details

sdk-nrf:

PR head: bf937c8ecb3d36d906c47323f05e3f1337c1bdab
merge base: 8fd42e59476cee555e0c9e519342cb47cf039401
target head (main): 0e1aa079ca4b14bee3516308306feb690cabaf21
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7) 
subsys
│  ├── net
│  │  ├── openthread
│  │  │  ├── rpc
│  │  │  │  ├── Kconfig
│  │  │  │  ├── client
│  │  │  │  │  │ ot_rpc_message.c
│  │  │  │  ├── server
│  │  │  │  │  │ ot_rpc_message.c
tests
│  ├── subsys
│  │  ├── net
│  │  │  ├── openthread
│  │  │  │  ├── rpc
│  │  │  │  │  ├── server
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  ├── coap_suite.c
│  │  │  │  │  │  │  ├── common_fakes.c
│  │  │  │  │  │  │  ├── common_fakes.h
│  │  │  │  │  │  │  │ message_suite.c

Outputs:

Toolchain

Version: 8611848abf
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:8611848abf_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 528
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-ps
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@canisLupus1313 canisLupus1313 force-pushed the msg_framework_almost branch 2 times, most recently from 0ce49fb to aa6a7a9 Compare November 15, 2024 00:12
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Damian-Nordic
Damian-Nordic approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and suggestions but lgtm otherwise.

subsys/net/openthread/rpc/Kconfig Outdated Show resolved Hide resolved
subsys/net/openthread/rpc/Kconfig Outdated Show resolved Hide resolved
tests/subsys/net/openthread/rpc/server/src/message_suite.c Outdated Show resolved Hide resolved
tests/subsys/net/openthread/rpc/server/src/message_suite.c Show resolved Hide resolved
alxelax
alxelax reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@alxelax alxelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just two minor comments

subsys/net/openthread/rpc/Kconfig Outdated Show resolved Hide resolved
subsys/net/openthread/rpc/server/ot_rpc_message.c Outdated Show resolved Hide resolved
@canisLupus1313
nrf_rpc: Add test for ot_message allocations.
bf937c8 
Commit adds unit tests for ot message manipulation in nrf rpc Openthread
part.

Signed-off-by: Przemyslaw Bida <[email protected]>
@nordicjm nordicjm merged commit 78d6882 into nrfconnect:main Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@alxelax alxelax alxelax approved these changes

@nordicjm nordicjm nordicjm approved these changes

@gmarull gmarull gmarull approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@canisLupus1313 @NordicBuilder @gmarull @nordicjm @alxelax @Damian-Nordic